Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible service worker error in Firefox #17139

Merged
merged 2 commits into from Jan 26, 2021
Merged

Fix possible service worker error in Firefox #17139

merged 2 commits into from Jan 26, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 24, 2021

Description:

fix #17136

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 24, 2021
@tsteur tsteur added this to the 4.2.0 milestone Jan 24, 2021
@tsteur tsteur mentioned this pull request Jan 24, 2021
Closed
@tsteur
Copy link
Member Author

tsteur commented Jan 25, 2021

build js

sgiehl
sgiehl reviewed Jan 25, 2021
View reviewed changes
js/piwik.js Show resolved Hide resolved
@tsteur tsteur merged commit c8959ca into 4.x-dev Jan 26, 2021
@tsteur tsteur deleted the m17136 branch January 26, 2021 18:30
@brainfoolong
Copy link
Contributor

Hi! Thanks for this fix. Should this be already in 4.2.1? Currently we still get this errors with Firefox 87.0 and Matomo 4.2.1. Greetz

@brainfoolong
Copy link
Contributor

Nevermind. I cant reproduce this error now, seems to be a cache from old matomo version in the browser of a client. Sorry for this comment :)

@brainfoolong brainfoolong mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Error in console when trying to communicate with service worker in Firefox with persistant cookies disabled
3 participants
@tsteur @brainfoolong @sgiehl