Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tag Manager submodule #17131

Merged
merged 1 commit into from Jan 22, 2021
Merged

Update Tag Manager submodule #17131

merged 1 commit into from Jan 22, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 21, 2021

There were various merged in the tag manager submodule

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Jan 21, 2021
@tsteur tsteur added this to the 4.2.0 milestone Jan 21, 2021
@diosmosis diosmosis merged commit 1f52bbf into 4.x-dev Jan 22, 2021
@diosmosis diosmosis deleted the updatet4 branch January 22, 2021 03:33
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @diosmosis @mattab