Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PerformanceNavigationTiming API if available #17130

Merged
merged 4 commits into from Jan 26, 2021
Merged

Use PerformanceNavigationTiming API if available #17130

merged 4 commits into from Jan 26, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 21, 2021

Description:

fixes #17102

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 21, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Jan 21, 2021
@sgiehl sgiehl force-pushed the performancejs branch 3 times, most recently from 76c7e2d to 643a273 Compare January 21, 2021 16:18
diosmosis
diosmosis reviewed Jan 22, 2021
View reviewed changes
js/piwik.js Show resolved Hide resolved
@sgiehl
Copy link
Member Author

sgiehl commented Jan 22, 2021

build js

@diosmosis diosmosis merged commit 8f5961e into 4.x-dev Jan 26, 2021
@diosmosis diosmosis deleted the performancejs branch January 26, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

PerformanceTiming API used by Matomo is deprecated, use PerformanceNavigationTiming if available
2 participants
@sgiehl @diosmosis