Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'console customdimensions:add-custom-dimension' does nothing #17126

Closed
voxspox opened this issue Jan 20, 2021 · 4 comments
Closed

'console customdimensions:add-custom-dimension' does nothing #17126

voxspox opened this issue Jan 20, 2021 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@voxspox
Copy link

voxspox commented Jan 20, 2021

I want to have more than 5 custom dimension. Thus I call:

php console customdimensions:add-custom-dimension --scope=visit -vvv

Because I have no SSH access to the server I call this command via php passthru over the webbrowser.

The output is:

Adding 1 Custom Dimension(s) in scope visit.
This causes schema changes in the database and may take a very long time.

return code: 0

The output and the return code is displayed instantly. Seems to be fast.

But on the configuration page for Custom Dimensions the button still says: "Configure a new dimension (0 of 5 dimensions left)"

Also, I'm wondering why there is no verbose output.

I know using passthru is a bit hacky, but maybe someone has a hint for me :)

using matomo: 4.1.1
@tsteur
Copy link
Member

tsteur commented Jan 20, 2021

@voxspox you need to add --no-interaction as there would be usually a confirmation question.

@tsteur tsteur closed this as completed Jan 20, 2021
@tsteur tsteur added the answered For when a question was asked and we referred to forum or answered it. label Jan 20, 2021
@voxspox
Copy link
Author

voxspox commented Jan 20, 2021

works!

@voxspox
Copy link
Author

voxspox commented Jan 21, 2021

@tsteur I think the error code of the script should not be 0 then. 0 means success, but in this scenario the task "add dimensions" was not successful, it was aborted.

@tsteur
Copy link
Member

tsteur commented Jan 21, 2021

@voxspox I'm not sure what common behaviour in such situations is. If you were to execute this on the console then you would have been asked whether you want to execute this action or not. If you select "no" it seems to me that maybe an exit code of 0 is correct as it correctly exited and did nothing as requested. But not sure if linux / command line behaviour is usually different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsteur @voxspox