Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegmentEditorUI #17125

Closed
jorgeuos opened this issue Jan 20, 2021 · 3 comments
Closed

SegmentEditorUI #17125

jorgeuos opened this issue Jan 20, 2021 · 3 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@jorgeuos
Copy link

Our clients are frequent users of Segments, it's one of their most used feature actually.
We have taken the first steps to create an MVP.

Progress will be updated here and if anyone interested in helping out, just reach out.
Any thoughts or ideas are highly appreciated.

Features:

  • Create a menu item for Segments
  • Add user permission checks
  • List segments
  • Add intuitive buttons for manipulating segments using SegmentEditor plugin
  • Add tests (Unit tests, Behavioural tests)
  • Create PR to Matomo; plugin-SegmentEditorUI

Nice to have features:

  • Quick link to overview
  • Validate segment

Quick mockup:
SegmentEditorUI

Br, Jorge

@jorgeuos
Copy link
Author

@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jan 20, 2021
@tsteur
Copy link
Member

tsteur commented Jan 20, 2021

@jorgeuos nice mockup. I reckon some of the things we wouldn't want in core so there would be always the possibility to put this into a plugin. For example we wouldn't want to have this in the left menu as entities are usually not really managed there unless it is a reporting entity like "Goals" etc. Maybe there could be instead some button in the segment selector similar to
image

In the table we would likely also hide some information like "idsegment" and maybe even "definition" (as they can be quite long and cryptic to most users and the name should already say enough). Other columns could be technically only shown if it's a superuser or so like "login". Or maybe it be not too important and could only be shown when editing a segment etc.

@mattab
Copy link
Member

mattab commented May 15, 2023

Duplicate of ##20659

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
@sgiehl sgiehl added the duplicate For issues that already existed in our issue tracker and were reported previously. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

4 participants