Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility with jQuery 3 #17121

Merged
merged 1 commit into from Jan 20, 2021
Merged

Improve compatibility with jQuery 3 #17121

merged 1 commit into from Jan 20, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 19, 2021

Description:

Which is used in WordPress 5.6+

Also adjusted few premium features with similar issue. refs matomo-org/matomo-for-wordpress#414

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur
Improve compatibility with jQuery 3
fc5b5ee 
Which is used in WordPress 5.6+

Also adjusted few premium features with similar issue. refs matomo-org/matomo-for-wordpress#414
@tsteur tsteur added the Needs Review PRs that need a code review label Jan 19, 2021
@tsteur tsteur added this to the 4.2.0 milestone Jan 19, 2021
@sgiehl sgiehl merged commit f538b0b into 4.x-dev Jan 20, 2021
@sgiehl sgiehl deleted the wp414 branch January 20, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl