Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tagmanager submodule #17114

Merged
merged 1 commit into from Jan 19, 2021
Merged

update tagmanager submodule #17114

merged 1 commit into from Jan 19, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 18, 2021

Description:

refs matomo-org/tag-manager#295

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 18, 2021
@tsteur tsteur added this to the 4.2.0 milestone Jan 18, 2021
@diosmosis diosmosis merged commit ced89d0 into 4.x-dev Jan 19, 2021
@diosmosis diosmosis deleted the tagmaupdate branch January 19, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis