Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest release of JShrink instead of dev-master #17112

Merged
merged 1 commit into from Jan 19, 2021
Merged

Use latest release of JShrink instead of dev-master #17112

merged 1 commit into from Jan 19, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 18, 2021

Description:

We were using a specific commit on master branch to already have the PHP 8 compatible version.
As there was a new release just now, which includes those PHP 8 fixes, we should switch back using a version requirement

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 18, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Jan 18, 2021
@sgiehl sgiehl requested a review from diosmosis January 18, 2021 08:44
@diosmosis diosmosis merged commit a2d9b0a into 4.x-dev Jan 19, 2021
@diosmosis diosmosis deleted the jshrink branch January 19, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis