Add informational diagnostic for archive invalidations table. #17110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsteur does this look useful to you? |
|
Yes that sounds good. Anything that will help us troubleshoot and understand things easier/quick is good 👍 Especially around archiving which is usually the most difficult one |
sgiehl
approved these changes
Feb 24, 2021
|
@diosmosis UI test needs to be updated before merging |
|
@diosmosis the UI file you've added here is not on LFS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new informational diagnostic to get information about rows in the invalidations table. @tsteur do you see value in this? If so I will add a test.
Review