@Findus23 opened this Pull Request on January 15th 2021 Member

I am not sure if I understand the issue correctly, but I think it should be possible to call enableLinkTracking multiple times.

reported in https://forum.matomo.org/t/enablelinktracking-re-scan-dom-after-content-changes/40269

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on January 17th 2021 Member

LGTM, would be good to have a test for it in tests/javascript/index.php

@tsteur commented on January 17th 2021 Member

build js

@tsteur commented on January 17th 2021 Member

👍 indeed it can be called multiple times

@Findus23 commented on January 18th 2021 Member

It would be great if someone else could create the test as I don't have a great overview over tests/javascript/index.php and not enough time to more closely look into it.

@tsteur commented on January 18th 2021 Member

@Findus23 I reckon it's fine it wouldn't need a test and be quite hard to test actually

This Pull Request was closed on January 18th 2021
Powered by GitHub Issue Mirror