Fix AngularJS tests #17100
Merged
Fix AngularJS tests #17100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AngularJS tests are currently always failing as PhantomJS doesn't seem to start up correctly.
Seems there was a new release of Karma (6.0.0), which causes the problem. As we are currently requiring Karama
>= 0.12.1only, it automatically used the new version for testing.I've added a
< 6.0.0for the Karma requirement. This ensures the version 5.2 is used again.Will merge this for now, so tests are running again.
@tsteur @diosmosis Not sure if we should have a look somewhen why it actually doesn't work with Karma 6. Feel free to create an issue if that is something we should look into...