Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable_auto_update option misleading #17096

Closed
vrandr opened this issue Jan 15, 2021 · 2 comments · Fixed by #17105
Closed

enable_auto_update option misleading #17096

vrandr opened this issue Jan 15, 2021 · 2 comments · Fixed by #17105
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@vrandr
Copy link

vrandr commented Jan 15, 2021

I think the enable_auto_update option can be a little bit confusing.

What it does

Disable the "automatic update check".

Confusion

Does it disable the Update Automatically function in the Web UI or not.

Steps to reproduce

  1. Setting enable_auto_update to 0
  2. Update Automatically option is still available in the Web UI (CoreUpdater action newVersionAvailable)
  3. Updating the instance is possible
  4. After the successful update you'll receive an error: An error occurred: Auto updater is disabled

Expected behavior

After setting enable_auto_update to 0 updates over the Web UI aren't possible any more.
tsteur added a commit that referenced this issue Jan 17, 2021
@tsteur
Disable newVersionAvailable when auto update enabled.
d3ae381 
fix #17096
@tsteur tsteur mentioned this issue Jan 17, 2021
Merged
9 tasks
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 17, 2021
@tsteur
Copy link
Member

tsteur commented Jan 17, 2021

Cheer @vrandr technically, it was kind of already working because when disabled, Matomo would no longer look if an update is available. The method you mentioned would still work though if at the time of disabling a newer version was available. Added #17105 for now.

diosmosis pushed a commit that referenced this issue Jan 18, 2021
@tsteur
Disable newVersionAvailable when auto update enabled. (#17105)
6e102bf 
fix #17096
@Findus23
Copy link
Member

I think #17106 is the correct linked issue.

@mattab mattab mentioned this issue Feb 22, 2021
Closed
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable newVersionAvailable when auto update enabled. matomo-org/matomo
4 participants
@tsteur @mattab @Findus23 @vrandr