Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation missed on "Create a new user" #17086

Closed
math-GH opened this issue Jan 13, 2021 · 1 comment · Fixed by #17293
Closed

Translation missed on "Create a new user" #17086

math-GH opened this issue Jan 13, 2021 · 1 comment · Fixed by #17293
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone

Comments

@math-GH
Copy link

math-GH commented Jan 13, 2021

The (German) translation is missed in the screen of "Create a new user"
grafik

Username = Benutzername
Password = Passwort
Email = E-Mail

See the wording in the table before
grafik

@Findus23 Findus23 added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 13, 2021
@Findus23
Copy link
Member

This does indeed seem to be hardcoded:

<div class="visibleTab col m10">
<div ng-if="$ctrl.activeTab === 'basic'" class="basic-info-tab">
<div
piwik-field
uicontrol="text"
name="user_login"
ng-model="$ctrl.user.login"
data-title="Username"
maxlength="100"
data-disabled="$ctrl.isSavingUserInfo || !$ctrl.isAdd"
>
</div>
<div
piwik-field
uicontrol="password"
name="user_password"
ng-model="$ctrl.user.password"
data-title="Password"
data-disabled="$ctrl.isSavingUserInfo || ($ctrl.currentUserRole != 'superuser' && !$ctrl.isAdd)"
ng-change="$ctrl.isPasswordModified = true"
>
</div>
<div
piwik-field
uicontrol="text"
name="user_email"
ng-model="$ctrl.user.email"
data-title="Email"
maxlength="100"
data-disabled="$ctrl.isSavingUserInfo || ($ctrl.currentUserRole != 'superuser' && !$ctrl.isAdd)"
ng-if="$ctrl.currentUserRole == 'superuser' || $ctrl.isAdd"
>
</div>
<div
piwik-field
uicontrol="site"
name="user_site"
ng-model="$ctrl.firstSiteAccess"
data-title="First website permission"
data-disabled="$ctrl.isSavingUserInfo"
ng-if="$ctrl.isAdd"
ui-control-attributes="{ onlySitesWithAdminAccess: true }"
ng-attr-inline-help="{{:: 'UsersManager_FirstSiteInlineHelp'|translate }}"
>
</div>

@sgiehl sgiehl added c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Jan 13, 2021
@tsteur tsteur added this to the 4.4.0 milestone Jan 13, 2021
@flamisz flamisz self-assigned this Mar 2, 2021
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants