New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
couple UI fixes for users management #17082
Conversation
The role dropdown still looks broken in chrome: This seems to be caused by the |
@sgiehl odd, it was working for me. I'll look again. |
@sgiehl i'm not able to reproduce: actually... was just able to reproduce. it only happens if you click on another select while one is open. Will fix by removing transform, much simple solution. |
That fix works for me on chrome. But shouldn't we make the font-size in the drop down smaller as well. Guess that was the case before (due to the transform of the parent element) Also I just found another issue in the user management. The role drop down is also showing the capabilities. Is that on purpose? Selecting one of the capabilities even doesn't add it for the user. |
I'm not sure it's really needed. The transform was just so it didn't stretch out the rows in the table. Personally I don't think it really matters the dropdown font is different. I can change it if needed, though. |
@diosmosis we can also keep it that way. But imho the drop down content looks a bit oversized, compared to the other elements. |
@sgiehl updated the dropdown text height: |
@diosmosis looks better now. Would be good to merge from my side. But there are a couple of UI tests failing due to this changes... |
Description:
Contains the following fixes:
Fixes #17079
Review