Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --skip-idsites regression and increment processed site count properly. #17081

Merged
merged 1 commit into from Jan 13, 2021
Merged

Fix --skip-idsites regression and increment processed site count properly. #17081

merged 1 commit into from Jan 13, 2021

Conversation

diosmosis
Copy link
Member

Description:

Fixes #17074. Also includes a test.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 13, 2021
@diosmosis diosmosis added this to the 4.2.0 milestone Jan 13, 2021
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 13, 2021
@sgiehl sgiehl merged commit 8c792dc into 4.x-dev Jan 13, 2021
@sgiehl sgiehl deleted the 17074-skip-idsites branch January 13, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

--skip-idsites argument to core:archive works like --force-idsites in 4.x
2 participants
@diosmosis @sgiehl