Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--skip-idsites argument to core:archive works like --force-idsites in 4.x #17074

Closed
Callidior opened this issue Jan 11, 2021 · 1 comment · Fixed by #17081
Closed

--skip-idsites argument to core:archive works like --force-idsites in 4.x #17074

Callidior opened this issue Jan 11, 2021 · 1 comment · Fixed by #17081
Assignees
@diosmosis
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.2.0

Comments

@Callidior
Copy link

When specifying --skip-idsites in a CLI call to core:archive, it will actually process only these sites instead of skipping them.

The current implementation looks like this:

if (!empty($this->shouldSkipSpecifiedSites)) {
    $websiteIds = array_intersect($websiteIds, $this->shouldSkipSpecifiedSites);
}

I guess it should use array_diff instead of array_intersect.
@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jan 12, 2021
@tsteur tsteur added this to the 4.2.0 milestone Jan 12, 2021
@tsteur
Copy link
Member

tsteur commented Jan 12, 2021

Thanks for finding this regression @Callidior 👍 Very appreciated

@diosmosis diosmosis self-assigned this Jan 13, 2021
@diosmosis diosmosis mentioned this issue Jan 13, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

Fix --skip-idsites regression and increment processed site count properly. matomo-org/matomo
3 participants
@diosmosis @tsteur @Callidior