@sgiehl opened this Pull Request on January 11th 2021 Member

Description:

fixes #16793

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on January 11th 2021 Member

Note: UI tests in submodules may need to be updated before merging

@Findus23 commented on January 12th 2021 Member

It's quite minor, but for me (in Firefox) the animations wobble a bit when the transition ends and it is replaced with the static style. Maybe there is some padding/margin too much.

https://user-images.githubusercontent.com/6266037/104309628-c0d54600-54d2-11eb-89f7-cc4e39c30240.mp4

@sgiehl commented on January 12th 2021 Member

seems to be caused by the switch between overflow:visible and overflow:hidden. Will look for a fix...

This Pull Request was closed on January 12th 2021
Powered by GitHub Issue Mirror