Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make admin menu collapsible #17073

Merged
merged 6 commits into from Jan 12, 2021
Merged

Make admin menu collapsible #17073

merged 6 commits into from Jan 12, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 11, 2021

Description:

fixes #16793

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 11, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Jan 11, 2021
@sgiehl sgiehl marked this pull request as ready for review January 11, 2021 15:26
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jan 11, 2021
@sgiehl
Copy link
Member Author

sgiehl commented Jan 11, 2021

Note: UI tests in submodules may need to be updated before merging

diosmosis
diosmosis approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, worked locally, good to merge once UI tests pass

@sgiehl sgiehl merged commit 5934d5e into 4.x-dev Jan 12, 2021
@sgiehl sgiehl deleted the collapsibleadminmenu branch January 12, 2021 11:13
@Findus23
Copy link
Member

It's quite minor, but for me (in Firefox) the animations wobble a bit when the transition ends and it is replaced with the static style. Maybe there is some padding/margin too much.

test-2021-01-12_12.35.05.mp4

@sgiehl
Copy link
Member Author

sgiehl commented Jan 12, 2021

seems to be caused by the switch between overflow:visible and overflow:hidden. Will look for a fix...

@sgiehl sgiehl mentioned this pull request Jan 12, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Admin menu should be collapsible for admins/super users
3 participants
@sgiehl @Findus23 @diosmosis