Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use confiugred noreply mail address when sending recovery mails #17072

Merged
merged 1 commit into from Jan 12, 2021
Merged

Use confiugred noreply mail address when sending recovery mails #17072

merged 1 commit into from Jan 12, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 11, 2021

Description:

Removes the settings for login_password_recovery_email_address and login_password_recovery_name

fixes #17026

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 11, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Jan 11, 2021
@diosmosis diosmosis merged commit 0d97942 into 4.x-dev Jan 12, 2021
@diosmosis diosmosis deleted the recoverysmtp branch January 12, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Password recovery SMTP email configuration
2 participants
@sgiehl @diosmosis