New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display help icons for categories/subcategories #17062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diosmosis currently, it shows the help icons for the currently selected ones The help icon on the main category talks about the reporting page but probably needs to talk about the "visitors report pages" I don't know if it's easily possible but be great to adjust the titles like below
If it's too complicated can also not do it. And generally I wonder if it was better to only show the help icons for the currently hovered reporting category/page. Because we then adjusted the text to not refer to the current reporting page this would be possible. Of course it might be confusing to see a report help for one page in the context of a different page so we could also additionally switch the page and show the help text at once. That's just a thought though because I found it visually bit cluttered when hovering another menu item and the other two question marks are still shown. Eg here I hover "real time map" and I wonder if the other two question marks should disappear and it should be instead only be shown for the real time map. A problem be though that when clicking on the reporting category there is no page to show so maybe it doesn't work. For sections we could otherwise just show it as part of the current page though maybe. Personally, I would maybe show the help icon only for reporting pages. Waiting for the thoughts from @mattab |
It's do-able.
Switching the page is a possibility. I can try this and we can revert if it's weird. Though actually, seeing a help icon on hover for every category on the left might be weird too... I guess we can do it on hover of a single menu item. I'll try this.
Makes sense for a first version. |
The UI looks good overall 👍 (feedback below)
Agreed 👍 the help icon can be removed from the top menus and only show for the current reporting page (on hover). Also a small note but in terms of UX, because the icon is tiny (good for visual effect), it's (very) hard to click on it. Also on hover on the icon, could we maybe show the colored icon? (to show some feedback and hint that clicking might do something). (similar to how it shows blue when hovering the icon next to a report's title) |
btw. should we at some point mention those category classes on https://developer.matomo.org/guides/menus ? |
👍 now only need to wait for the help texts. We could already merge though and them later to avoid more merge conflicts later |
Some tests are failing due to the changes. @diosmosis could you update them so we can get that merged? |
The help texts are almost done I think. We can wait until then and I'll set them in this PR so I don't have to update expected test files twice. |
Description:
Adds a new notification type (not made public or advertised) for category/subcategory documentation. Also changes the styling for the in-report help icon, but doesn't make it permanently visible. Might be a good idea to do that I guess, but I wasn't sure.
Fixes #13716
Review