Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limited visits query when sorting ascending #17060

Merged
merged 2 commits into from Jan 8, 2021
Merged

Fix limited visits query when sorting ascending #17060

merged 2 commits into from Jan 8, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 7, 2021

Description:

fixes #16394

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 7, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Jan 7, 2021
@diosmosis diosmosis merged commit d9a3cc0 into 4.x-dev Jan 8, 2021
@diosmosis diosmosis deleted the vlogasc branch January 8, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looping with filter_limit and filter_offset does not always get all visits
2 participants