Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no longer used node module files are removed on update #17059

Merged
merged 1 commit into from Jan 8, 2021
Merged

Ensure no longer used node module files are removed on update #17059

merged 1 commit into from Jan 8, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 7, 2021

Description:

refs #16938

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jan 7, 2021
@sgiehl sgiehl added this to the 4.2.0 milestone Jan 7, 2021
@diosmosis diosmosis merged commit a924346 into 4.x-dev Jan 8, 2021
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Jan 15, 2021
@sgiehl sgiehl deleted the fixupdatenm branch January 27, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @diosmosis @mattab