Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent update installation failing because of selinux/file system protection result in an broken system. #17054

Closed
tuxmaster5000 opened this issue Jan 6, 2021 · 1 comment · Fixed by #18594
Assignees
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Stability For issues that make Matomo more stable and reliable to run for sys admins.
Milestone

Comments

@tuxmaster5000
Copy link

I have seen on more systems that the update fails in the middle of the update process, because some files/directory's are not writable for the update. So when this happens the installation is broken, because it is an mix of the old and the new version. Other php projects like nextcloud have an checker build in, which tests the files/directory for writing before and print out which items must fixed, before the update itself starts. I think this feature will be very useful also for matomo,

@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Stability For issues that make Matomo more stable and reliable to run for sys admins. labels Jan 10, 2021
@tsteur tsteur added this to the 4.4.0 milestone Jan 10, 2021
@tsteur
Copy link
Member

tsteur commented Jan 10, 2021

Thanks for creating this issue @tuxmaster5000 that would be useful indeed to make sure the updater works in most cases as otherwise people might stop using us as soon as the update fails. As part of this issue let's check if directories are writiable and if that's easy to do first before fully developing it. AKA if it would be a bigger job we'd need to maybe reschedule it.

@peterhashair peterhashair self-assigned this Jan 9, 2022
@peterhashair peterhashair linked a pull request Jan 10, 2022 that will close this issue
11 tasks
@justinvelluppillai justinvelluppillai modified the milestones: 4.7.0, 4.8.0 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Stability For issues that make Matomo more stable and reliable to run for sys admins.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants