small archiving invalidation loop optimization #17045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specific period + add total iterations counter to output.
sgiehl
requested changes
Jan 7, 2021
|
@sgiehl applied review comments |
sgiehl
reviewed
Jan 8, 2021
core/DataAccess/Model.php
Outdated
| if ($onlySelectSegmentArchives) { | ||
| // we select only segment archiving by looking for archive done flags that have a length > 32. this works since the done flag | ||
| // for a segment archive will contain its hash | ||
| $sql .= " AND CHAR_LENGTH(name) > 32 AND date1 = ? AND date2 = ? AND period = ?"; |
There was a problem hiding this comment.
Regarding the 32 chars. Wouldn't that also select invalidations for plugins with long names. e.g. SearchEngineKeywordsPerformance actually already has 32 chars 🙈
I'm not deep enough into the code here to be sure if that cause any issues or not.
There was a problem hiding this comment.
Yeah this could be an issue then. I guess we also have to do a split or something...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Select less invalidations when we know were archiving segments for a specific period + add total iterations counter to output.
When we're archiving an "All Visits" archive, we know we won't be adding segments to it, so every segment archive we query will be skipped. So it's pointless to query for them all. This PR avoids selecting them so we don't have to go through the loop for them. May provide a visible performance boost in cases where there are many segments for a site.
FYI @tsteur
Review