@diosmosis opened this Pull Request on January 5th 2021 Member

Description:

Select less invalidations when we know were archiving segments for a specific period + add total iterations counter to output.

When we're archiving an "All Visits" archive, we know we won't be adding segments to it, so every segment archive we query will be skipped. So it's pointless to query for them all. This PR avoids selecting them so we don't have to go through the loop for them. May provide a visible performance boost in cases where there are many segments for a site.

FYI @tsteur

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on January 8th 2021 Member

@sgiehl applied review comments

This Pull Request was closed on March 25th 2021
Powered by GitHub Issue Mirror