Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing build #17043

Merged
merged 1 commit into from Jan 5, 2021
Merged

fixing build #17043

merged 1 commit into from Jan 5, 2021

Conversation

diosmosis
Copy link
Member

Description:

Update screenshots + fix issue introduced by using CURLOPT_ENCODING => "". W/ this option it's possible for curl to get gzip encoded data, where $fileSize != $fileLength (where fileLength is the data returned in the stream_. Instead now we only compare $fileSize and $contentLength.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added this to the 4.2.0 milestone Jan 5, 2021
@diosmosis diosmosis changed the title fixing build (including change to Http.php check that stream bytes == file size) fixing build Jan 5, 2021
@diosmosis diosmosis merged commit b4c1760 into 4.x-dev Jan 5, 2021
@diosmosis diosmosis deleted the fix-build branch January 5, 2021 02:48
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants