Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL fieldsize in log_visit for location_region to small #17042

Closed
grzchr15 opened this issue Jan 4, 2021 · 1 comment
Closed

SQL fieldsize in log_visit for location_region to small #17042

grzchr15 opened this issue Jan 4, 2021 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Milestone
Backlog (Help wan...

Comments

@grzchr15
Copy link

grzchr15 commented Jan 4, 2021

Currently there are various functions getRegionNames() which work for MaxMind/Wikipedia regions and get cropped to 3 chars at SQL schema.
If Intranet Regions are longer this field must be increased in size.
For example office regions are up to 20 chars in my use case.

A patched version of GeoIp2 with adding https://github.com/grzchr15/IntranetGeoIP can so track both Intranet and Internet regions.

https://gist.github.com/grzchr15/dfc8e975482ad99e94b620b033da1da5
@sgiehl
Copy link
Member

sgiehl commented Jan 5, 2021

The location_region column was designed to store ISO region codes. Using it for something else might work though, but I would suggest using a new column if you want to store something else in there

@tsteur tsteur added this to the Backlog (Help wanted) milestone Jan 6, 2021
@tsteur tsteur added the Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. label Jan 6, 2021
@sgiehl sgiehl closed this as completed Oct 9, 2023
@sgiehl sgiehl added answered For when a question was asked and we referred to forum or answered it. and removed Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@grzchr15 @tsteur @sgiehl