Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password recovery SMTP email configuration #17026

Closed
wlabarron opened this issue Dec 28, 2020 · 4 comments · Fixed by #17072
Closed

Password recovery SMTP email configuration #17026

wlabarron opened this issue Dec 28, 2020 · 4 comments · Fixed by #17072
Assignees
@sgiehl
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.2.0

Comments

@wlabarron
Copy link

I'm setting up SMTP email using the web interface (System > General settings > Email server settings) and it provides the option to set an SMTP From Address.

It seems like this field sets the config option noreply_email_address (global.ini.php#L474), but not login_password_recovery_email_address (global.ini.php#L421).

This means that my SMTP server rejects any password recovery emails, since Matomo tries to send it using the default password recovery email address, which the SMTP user isn't authorised to send as.

Perhaps a fix for this would be to change the SMTP From address option in the web interface to update both emails in the config? Or perhaps to add another form field in the web interface to set the two addresses separately?
@tsteur
Copy link
Member

tsteur commented Dec 29, 2020

@mattab why do we have a login_password_recovery_email_address? I suppose both users would need to have the same password for this to work.

@wlabarron
Copy link
Author

The current Matomo settings interface has fields for SMTP Username (global.ini.php#L985), SMTP password (global.ini.php#L986), and SMTP From address (noreply_email_address). This setup means one SMTP username and password needs to be able to send as noreply_email_address and login_password_recovery_email_address.

@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 30, 2020
@tsteur tsteur added this to the 4.4.0 milestone Dec 30, 2020
@tsteur
Copy link
Member

tsteur commented Dec 30, 2020

fyi was made configurable in #527 in 2009.

It was added in 68eb786#diff-801809c140d123b729100c6dd8097fd6954dff224a290112ed910bb8e33c577c in 2008.

I suppose there is no particular reason for this and we could simply remove it and use the regular from.

@mattab
Copy link
Member

mattab commented Dec 30, 2020

Sounds good to use the regular from 👍

@tsteur tsteur modified the milestones: 4.4.0, 4.2.0 Jan 10, 2021
@tsteur tsteur mentioned this issue Jan 10, 2021
Closed
@sgiehl sgiehl self-assigned this Jan 11, 2021
@sgiehl sgiehl mentioned this issue Jan 11, 2021
Merged
9 tasks
@sgiehl sgiehl mentioned this issue Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

Use confiugred noreply mail address when sending recovery mails matomo-org/matomo
4 participants
@tsteur @mattab @sgiehl @wlabarron