Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make “Compare To” translatable #17021

Merged
merged 1 commit into from Dec 31, 2020
Merged

Make “Compare To” translatable #17021

merged 1 commit into from Dec 31, 2020

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Dec 25, 2020

Description:

The string “Compare To” in the period dialog is not translateable.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added this to the 4.2.0 milestone Dec 27, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 27, 2020
@diosmosis diosmosis merged commit 05f8915 into matomo-org:4.x-dev Dec 31, 2020
@diosmosis
Copy link
Member

Thanks for another contribution @c960657 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c960657 @diosmosis @tsteur