Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracking spam prevention plugin as a submodule #17016

Merged
merged 12 commits into from Jan 14, 2021
Merged

Add tracking spam prevention plugin as a submodule #17016

merged 12 commits into from Jan 14, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 24, 2020

Description:

See https://github.com/matomo-org/plugin-TrackingSpamPrevention for the features that were added.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur marked this pull request as draft December 24, 2020 00:48
@tsteur
Copy link
Member Author

tsteur commented Dec 24, 2020

@diosmosis @sgiehl I suppose it is normal that we run all the UI tests of a plugin with a submodule again? Like in https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/44659/
image

@diosmosis
Copy link
Member

@tsteur I think it's because we consider the plugins bundled w/ core to be tested this often (testing compatibility on every matomo change). Otherwise the tests would only run when the plugin changes, even though a change in core could cause problems.

@tsteur tsteur marked this pull request as ready for review January 11, 2021 20:57
@tsteur tsteur added the Needs Review PRs that need a code review label Jan 11, 2021
@tsteur tsteur added this to the 4.2.0 milestone Jan 11, 2021
@sgiehl
Copy link
Member

sgiehl commented Jan 14, 2021

Remaining test failures seem unrelated. Btw @tsteur did we decide if this plugin will be shipped with Matomo or if it will be available through Marketplace? We might need to adjust the build script maybe 🤔

@sgiehl sgiehl merged commit dcfd247 into 4.x-dev Jan 14, 2021
@sgiehl sgiehl deleted the trackingspam branch January 14, 2021 10:36
@tsteur
Copy link
Member Author

tsteur commented Jan 14, 2021

@sgiehl it should be not included in core but instead it is already on the marketplace. Do we need to adjust anything?

tsteur added a commit to matomo-org/matomo-package that referenced this pull request Jan 14, 2021
@tsteur
Do not ship TrackingSpamPrevention with Matomo core
6b1e97c 
@sgiehl is this what we need to add re matomo-org/matomo#17016 (comment) ?
@tsteur tsteur mentioned this pull request Jan 14, 2021
Closed
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tsteur @diosmosis @sgiehl @mattab