Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When "average generation time" is zero, hide the sparkline and "Avg generation time" graphs metric from picker #17010

Closed
mattab opened this issue Dec 23, 2020 · 7 comments · Fixed by #18078
Closed

When "average generation time" is zero, hide the sparkline and "Avg generation time" graphs metric from picker #17010

mattab opened this issue Dec 23, 2020 · 7 comments · Fixed by #18078
Assignees
@peterhashair
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.6.0

Comments

@mattab
Copy link
Member

mattab commented Dec 23, 2020

As a user, when i'm viewing a period where the "average generation time" is zero, for example under "Visitors > Overview", it would be helpful if:

  1. the sparkline "0 average generation time" is hidden
  2. and "Avg generation time" metric is removed from graphs metric picker

Context: currently this metric is shown for Matomo instances that used to track this metric (before Matomo 4). Which is helpful, but in this issue we just want to remove any confusion and hide the feature when it's definitely zero for the selected period.

Screenshot from 2020-12-24 09-23-04
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Dec 23, 2020
@mattab mattab mentioned this issue Dec 23, 2020
Closed
@tsteur tsteur added this to the Backlog (Help wanted) milestone Dec 23, 2020
@mattab mattab mentioned this issue Dec 23, 2020
Open
@mattab
Copy link
Member Author

mattab commented Dec 23, 2020

Otherwise if it's a bit too complex, instead of implementing the "smart" remove, we could just remove this metric completely, once we have implemented the new metric in #17013 - this would be good enough as people will be able to use the new metric now. (and would still be able to access the old metric in API)

@tsteur
Copy link
Member

tsteur commented Dec 23, 2020

@mattab was just going to say the same we could just remove it which would make it a lot easier independent of whether #17013 is implemented or not.

@fvdm
Copy link

fvdm commented Dec 24, 2020 •
edited

Do I understand it correctly that the old metric will then not be available for comparison in the UI anymore? Our non-dev users have to pull the raw data from the API? 👀

@mattab
Copy link
Member Author

mattab commented Mar 31, 2021

was just going to say the same we could just remove it which would make it a lot easier independent of whether #17013 is implemented or not.

👍 it would be great and ideally we can do it in 4.3.0 already then?

@basos9
Copy link

basos9 commented May 20, 2021

Hello,
Maybe this could be defered after #17013 is implemented for comparizon purposes

After upgrading to 4.3 (from 3.) we have this picture

image

which could be complemente by just overlapping the new metrics "avg. page load time"

@tsteur
Copy link
Member

tsteur commented Jul 27, 2021

As part of this issue we remove (not replace) the metric average generation time

@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Jul 27, 2021
@fvdm
Copy link

fvdm commented Jul 28, 2021

You are going to delete the historic page generation data?

@peterhashair peterhashair linked a pull request Sep 29, 2021 that will close this issue
When "average generation time" is zero, hide the sparkline and "Avg generation time" graphs metric from picker #18078
Merged
11 tasks
@justinvelluppillai justinvelluppillai modified the milestones: 4.7.0, 4.6.0 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.6.0
6 participants
@fvdm @tsteur @mattab @justinvelluppillai @basos9 @peterhashair