@sgiehl opened this Pull Request on December 23rd 2020 Member

Description:

This regressed with https://github.com/matomo-org/matomo/pull/16830/files#diff-3f15e6e8235bb796794c812a3c85b929cb82ae02f1dfbcd6e74e105d1fb31a6bL170-R170

fixes #16999

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on December 23rd 2020 Member

@sgiehl can you add a test for this?

@sgiehl commented on December 23rd 2020 Member

@diosmosis won't be able to do that the next days. Could you maybe have a look or maybe we create a followup issue for it.

@diosmosis commented on December 23rd 2020 Member

I'll take a look.

This Pull Request was closed on December 24th 2020
Powered by GitHub Issue Mirror