Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix report showing data of wrong date #17008

Merged
merged 4 commits into from Dec 24, 2020
Merged

Fix report showing data of wrong date #17008

merged 4 commits into from Dec 24, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 23, 2020

Description:

This regressed with https://github.com/matomo-org/matomo/pull/16830/files#diff-3f15e6e8235bb796794c812a3c85b929cb82ae02f1dfbcd6e74e105d1fb31a6bL170-R170

fixes #16999

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 23, 2020
@sgiehl sgiehl added this to the 4.2.0 milestone Dec 23, 2020
@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 23, 2020
@diosmosis
Copy link
Member

@sgiehl can you add a test for this?

@sgiehl
Copy link
Member Author

sgiehl commented Dec 23, 2020

@diosmosis won't be able to do that the next days. Could you maybe have a look or maybe we create a followup issue for it.

@diosmosis
Copy link
Member

I'll take a look.

@diosmosis diosmosis merged commit 04ac70e into 4.x-dev Dec 24, 2020
@diosmosis diosmosis deleted the fixtimezoneissue branch December 24, 2020 05:21
@Findus23 Findus23 mentioned this pull request Dec 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.2.0
3 participants
@sgiehl @diosmosis @tsteur