@diosmosis opened this Pull Request on December 23rd 2020 Member

Description:

Currently we check if a segment has been created or updated since the last time we invalidated in core:archive, and if so invalidate in the past. This is more complicated and error prone, it is far easier to just invalidate in the past in the SegmentEditor API.

Refs #16955

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on January 5th 2021 Member

Wondering if updating that behavior could lead to egde cases on update. E.g. if someone has a cron running only once nightly. After the cron ran a segment is changed and afterwards Matomo is update to that new behavior. The one changed segment won't get invalidated anymore, right? Would we need to do that once in an update maybe? 🤔

@diosmosis commented on January 6th 2021 Member

@sgiehl that makes sense, I'll add an update to check as well.

@diosmosis commented on January 6th 2021 Member

@sgiehl added the update

Powered by GitHub Issue Mirror