@diosmosis opened this Pull Request on December 23rd 2020 Member

Description:

Currently we check if a segment has been created or updated since the last time we invalidated in core:archive, and if so invalidate in the past. This is more complicated and error prone, it is far easier to just invalidate in the past in the SegmentEditor API.

Refs #16955

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on January 5th 2021 Member

Wondering if updating that behavior could lead to egde cases on update. E.g. if someone has a cron running only once nightly. After the cron ran a segment is changed and afterwards Matomo is update to that new behavior. The one changed segment won't get invalidated anymore, right? Would we need to do that once in an update maybe? 🤔

@diosmosis commented on January 6th 2021 Member

@sgiehl that makes sense, I'll add an update to check as well.

@diosmosis commented on January 6th 2021 Member

@sgiehl added the update

@diosmosis commented on January 28th 2021 Member

@sgiehl test should be fixed w/ the next build. the last change increases the amount of invalidated dates for segments, which I think is a bug fix. Before we were checking if the segment was created/edited after the earliest date for rearchiving, but it doesn't make sense to do that when invalidating for any report and not invalidating because of a segment.

@sgiehl commented on January 28th 2021 Member

@diosmosis seems there are still some test failures. Also one of my comments is still open. Besides that it would imho be good to merge. Not sure if maybe @tsteur would like to have another look on that.

@tsteur commented on January 28th 2021 Member

All good from my side. 👍

@diosmosis commented on February 3rd 2021 Member

@sgiehl fyi, fixed the tests and in doing so found another bug in the ArchiveInvalidator class. Before we were removing queued invalidations from tracking when invalidating any non-range period. But this meant that if we invalidated just a week, the day wouldn't get re-archived, even if there was a new visit.

Will wait to merge in case you want to do a new review of the change.

@diosmosis commented on February 4th 2021 Member

@sgiehl updated

This Pull Request was closed on February 4th 2021
Powered by GitHub Issue Mirror