Better fix for climulti segment encoding bug #17004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
https://forum.matomo.org/t/archive-web-cron-raises-invalid-log-visit-config-device-type/39981 occurs because double encoding the segment for curl requests does NOT work. Turns out the reason it's needed for climulti is because climulti does not set
$_SERVER['QUERY_STRING']
, but in Request that's where we get the segment variable passed on to API methods. This PR has the correct fix which is to set that server variable in RequestCommand.Review