@diosmosis opened this Pull Request on December 23rd 2020 Member

Description:

https://forum.matomo.org/t/archive-web-cron-raises-invalid-log-visit-config-device-type/39981 occurs because double encoding the segment for curl requests does NOT work. Turns out the reason it's needed for climulti is because climulti does not set $_SERVER['QUERY_STRING'], but in Request that's where we get the segment variable passed on to API methods. This PR has the correct fix which is to set that server variable in RequestCommand.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on December 23rd 2020
Powered by GitHub Issue Mirror