Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for QueueConsumer::shouldSkipArchiveBecauseLowerPeriodOrSegmentIsInProgress(). #16996

Merged
merged 2 commits into from Jan 5, 2021
Merged

Add unit test for QueueConsumer::shouldSkipArchiveBecauseLowerPeriodOrSegmentIsInProgress(). #16996

merged 2 commits into from Jan 5, 2021

Conversation

diosmosis
Copy link
Member

Description:

Add unit tests for this function since it had a bug in it and is generally not covered currently.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 22, 2020
@sgiehl
Copy link
Member

sgiehl commented Jan 4, 2021

@diosmosis the tests are actually failing on travis as the database isn't set up for unit tests. Guess you need to move them to integration tests?

@diosmosis diosmosis merged commit 27241f1 into 4.x-dev Jan 5, 2021
@diosmosis diosmosis deleted the queue-consumer-cli-test-check branch January 5, 2021 01:04
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @mattab