@diosmosis opened this Pull Request on December 22nd 2020 Member

Description:

Add unit tests for this function since it had a bug in it and is generally not covered currently.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on January 4th 2021 Member

@diosmosis the tests are actually failing on travis as the database isn't set up for unit tests. Guess you need to move them to integration tests?

This Pull Request was closed on January 5th 2021
Powered by GitHub Issue Mirror