In core:invalidate-report-data match segments by ID, name or definition ... #16994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Jan 5, 2021
|
Noticed this could potentially be a BC break for any automated uses of the command (since the user would have to add |
…on and warn when a definition does not match any known segment.
sgiehl
force-pushed
the
segment-invalidation-command
branch
from
d6c5ea9
to
50b7e4d
Compare
mattab
reviewed
Feb 19, 2021
| @@ -54,6 +62,7 @@ protected function configure() | |||
| $this->addOption('dry-run', null, InputOption::VALUE_NONE, 'For tests. Runs the command w/o actually ' | |||
| . 'invalidating anything.'); | |||
| $this->addOption('plugin', null, InputOption::VALUE_REQUIRED, 'To invalidate data for a specific plugin only.'); | |||
| $this->addOption('yes', null, InputOption::VALUE_NONE, 'Assume yes if an unrecognized segment is given.'); | |||
There was a problem hiding this comment.
Could we maybe clarify this help text as I don't quite get it? could the parameter name be maybe more clear?
There was a problem hiding this comment.
--ignore-unrecognized-segment? or --quiet/--force?
There was a problem hiding this comment.
It'd probably be better to just remove the check or make it just print out a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
.. and warn when a definition does not match any known segment. When invalidating segments, if it doesn't exactly match the encoding we want, the hash will be wrong and we won't invalidate what we want (and will trigger archiving of a segment we don't want). This change allows better matching and warns in case it doesn't match.
Review