@diosmosis opened this Pull Request on December 22nd 2020 Member

Description:

.. and warn when a definition does not match any known segment. When invalidating segments, if it doesn't exactly match the encoding we want, the hash will be wrong and we won't invalidate what we want (and will trigger archiving of a segment we don't want). This change allows better matching and warns in case it doesn't match.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on January 6th 2021 Member

Noticed this could potentially be a BC break for any automated uses of the command (since the user would have to add --yes in that case) so not merging just yet.

Powered by GitHub Issue Mirror