core:archive when looking for other climulti processes, also make sure idSite is same #16992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @tsteur |
sgiehl
reviewed
Dec 21, 2020
| @@ -397,18 +397,25 @@ private function shouldSkipArchiveBecauseLowerPeriodOrSegmentIsInProgress(array | |||
| continue; | |||
| } | |||
|
|
|||
| if (empty($archiveBeingProcessed['idSite']) | |||
There was a problem hiding this comment.
Haven't had a deeper look at the code, but should it actually happen that idSite isn't set for an archiving process? If so wouldn't we need to check if idSite of both aren't empty here? 🤔
There was a problem hiding this comment.
It's a bit confusing, but here $archiveBeingProcessed are the parameters for a climulti:request, while $archiveToProcess is a row in archive_invalidations. So idSite might not be set in a climulti:request execution, but idsite will always be in $archiveToProcess.
|
Seems tests are passing @diosmosis . is it good to merge? |
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As title. This is in case there are multiple archivers running on the same machine, we can pick up climulti requests for other sites.
Review