@diosmosis opened this Pull Request on December 21st 2020 Member

Description:

In case a user does not want to reveal a segment due to it having sensitive information, it can be hard to figure out exactly what the hash for a segment is (especially when there is an encoding or related problem). So adding it to the API output can be useful for debugging.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on January 5th 2021 Member

Added the test. also added the extra urlencode for the definition. Will wait until the other pr is merged before merging this one.

@flamisz commented on May 4th 2021 Contributor

which is the other pr you are waiting for? maybe it's merged already now?

@sgiehl commented on May 5th 2021 Member

I guess this one might meanwhile be obsolete. The hash should already be included in the API response. ping @diosmosis

@diosmosis commented on May 5th 2021 Member

Yes, unnecessary, closing this

This Pull Request was closed on May 5th 2021
Powered by GitHub Issue Mirror