Show segment hash in segmenteditor.getAll output to aid debugging. #16989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Jan 4, 2021
|
Added the test. also added the extra urlencode for the definition. Will wait until the other pr is merged before merging this one. |
flamisz
reviewed
May 4, 2021
| @@ -42,6 +42,27 @@ public function setUp(): void | |||
|
|
|||
| } | |||
|
|
|||
| public function test_getll_returnsCorrectHashes() | |||
|
which is the other pr you are waiting for? maybe it's merged already now? |
|
I guess this one might meanwhile be obsolete. The hash should already be included in the API response. ping @diosmosis |
|
Yes, unnecessary, closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In case a user does not want to reveal a segment due to it having sensitive information, it can be hard to figure out exactly what the hash for a segment is (especially when there is an encoding or related problem). So adding it to the API output can be useful for debugging.
Review