Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix potential error in reports purge query #16988

Merged
merged 2 commits into from Dec 21, 2020
Merged

fix potential error in reports purge query #16988

merged 2 commits into from Dec 21, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 20, 2020

Description:

should fix #16978

Thought it was a PHP 8 issue but looks like it's actually always been a bug maybe. I tweaked the code to reproduce this but in the end I think it happens maybe when you enable report purging but don't keep any periods or so.

Noticed must be this query because it says: near 'AND idarchive >= ? AND idarchive < ?' at line 3',

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 20, 2020
@tsteur tsteur added this to the 4.1.0 milestone Dec 20, 2020
@diosmosis diosmosis merged commit 8de1465 into 4.x-dev Dec 21, 2020
@diosmosis diosmosis deleted the m16978 branch December 21, 2020 00:04
@MichaIng
Copy link
Contributor

I can confirm this solved the errors, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

MySQLi syntax error "AND idarchive < ?' at line 3"
3 participants
@tsteur @MichaIng @diosmosis