Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core:archive reports "0 out of 4 archivers running currently" when --matomo-domain parameter is at the start of the command #16984

Closed
fealXX opened this issue Dec 20, 2020 · 1 comment · Fixed by #16987
Closed

core:archive reports "0 out of 4 archivers running currently" when --matomo-domain parameter is at the start of the command #16984

fealXX opened this issue Dec 20, 2020 · 1 comment · Fixed by #16987
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.0.x

Comments

@fealXX
Copy link

fealXX commented Dec 20, 2020

I noticed our Cronlogs always said "0 out of 4 archivers running currently" - regardless of the actual number of running archivers.

This was, because our cron for the core:archive job had the matomo-domain parameter in front of the core:archive command:
console --matomo-domain=my.matomodomain.com -vvv core:archive >> cron_daily.log
but CronArchive.php checks for strpos($process, 'console core:archive') !== false in hasReachedMaxConcurrentArchivers().

Changing the check to strpos($process, 'core:archive') !== false reports the correct number of running archivers.
@tsteur tsteur added this to the 4.0.x milestone Dec 20, 2020
@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 20, 2020
tsteur added a commit that referenced this issue Dec 20, 2020
@tsteur
Detect running archivers correctly
45d87c4 
fix #16984
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Dec 20, 2020
@tsteur tsteur mentioned this issue Dec 20, 2020
Merged
9 tasks
@tsteur
Copy link
Member

tsteur commented Dec 20, 2020

Thanks for reporting this @fealXX

diosmosis pushed a commit that referenced this issue Dec 20, 2020
@tsteur
Detect running archivers correctly (#16987)
c21faa1 
fix #16984
@mattab mattab changed the title Support other core:archive command formats for hasReachedMaxConcurrentArchivers() core:archive reports "0 out of 4 archivers running currently" when --matomo-domain parameter is at the start of the command Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging a pull request may close this issue.

Detect running archivers correctly matomo-org/matomo
2 participants
@tsteur @fealXX