Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wikimedia/less.php dependency to v3.1.0 or above #16981

Closed
MichaIng opened this issue Dec 19, 2020 · 1 comment · Fixed by #16976
Closed

Update wikimedia/less.php dependency to v3.1.0 or above #16981

MichaIng opened this issue Dec 19, 2020 · 1 comment · Fixed by #16976
Assignees
Milestone

Comments

@MichaIng
Copy link
Contributor

MichaIng commented Dec 19, 2020

The following warning is logged when running the web UI updater:

WARNING CoreUpdater 2020-12-19 17:05:44 UTC e415b /var/www/matomo/vendor/wikimedia/less.php/lib/Less/Tree/Directive.php(20): Deprecated - Required parameter $rules follows optional parameter $value - Matomo 4.1.0-b2

This is likely a PHP8.0 related deprecation. I see now it is from an external dependency, where it has been fixed recently: wikimedia/less.php@7b04e92

So take this as a request to update the less.php dependency to v3.1.0 or above.

@MichaIng MichaIng changed the title [PHP8.0] CoreUpdater: Required parameter $rules follows optional parameter $value [PHP8.0] Update wikimedia/less.php dependency to v3.1.0 or above Dec 19, 2020
@sgiehl sgiehl linked a pull request Dec 19, 2020 that will close this issue
9 tasks
@sgiehl
Copy link
Member

sgiehl commented Dec 19, 2020

see #16976

@sgiehl sgiehl self-assigned this Dec 21, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Dec 21, 2020
@mattab mattab changed the title [PHP8.0] Update wikimedia/less.php dependency to v3.1.0 or above Update wikimedia/less.php dependency to v3.1.0 or above Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants