Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve action id lookup for segments #16977

Merged
merged 2 commits into from Dec 23, 2020
Merged

Improve action id lookup for segments #16977

merged 2 commits into from Dec 23, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 18, 2020

Description:

If no id can be found for a segment with the normalized value, try looking it up the the original value

fixes #11806

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 18, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Dec 18, 2020
@sgiehl
Improve action id lookup fog segments
6d16852 
if no id can be found for a segment with the normalized value, try looking it up the the original value
@sgiehl sgiehl marked this pull request as ready for review December 21, 2020 10:25
@sgiehl sgiehl added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Dec 21, 2020
@mattab mattab modified the milestones: 4.1.0, 4.2.0 Dec 21, 2020
@diosmosis diosmosis merged commit 1c2502b into 4.x-dev Dec 23, 2020
@diosmosis diosmosis deleted the segmentencoding branch December 23, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Segmented visitor log does not load any content when the Outlink URL or Download URL contains an ampersand
3 participants
@sgiehl @diosmosis @mattab