Update wikimedia/less.php dependency #16976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
tsteur
reviewed
Dec 20, 2020
| @@ -25,7 +25,7 @@ | |||
| }, | |||
| "config": { | |||
| "platform": { | |||
| "php": "7.2.5" | |||
| "php": "7.2.9" | |||
There was a problem hiding this comment.
is this upgrade necessary? Does it mean we no longer support 7.2.5 as a minimum version @sgiehl ?
There was a problem hiding this comment.
That's the platform override value. So composer assumes 7.2.9 is installed, but the requirement is still set to 7.2.5
There was a problem hiding this comment.
@tsteur we maybe should merge this if possible before releasing a new version, as there might otherwise be issues on PHP 8
There was a problem hiding this comment.
@sgiehl planning to merge in a bit. https://github.com/wikimedia/less.php/blob/master/composer.json#L21 mentions it requires 7.2.9 so hoping it will still run on 7.2.5 (was changed in wikimedia/less.php@28baca4)
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We need to update wikimedia/less.php as the new release has some fixes for PHP 8.
I had to overwrite the composer platform config to PHP 7.2.9, as wikimedia/less.php requires PHP 7.2.9.
It should work with 7.2.5 as well, see wikimedia/less.php#50 (comment)
refs #16897
Review