Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core:archive Detection of archive process already in progress does not check for instance ID #16973

Closed
tsteur opened this issue Dec 17, 2020 · 0 comments · Fixed by #16974
Closed

core:archive Detection of archive process already in progress does not check for instance ID #16973

tsteur opened this issue Dec 17, 2020 · 0 comments · Fixed by #16974
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.0.x

Comments

@tsteur
Copy link
Member

tsteur commented Dec 17, 2020

@diosmosis I think there might be a bug which we noticed on cloud as in https://github.com/matomo-org/matomo/blob/4.x-dev/core/CliMulti/RequestParser.php#L63-L96 it’s maybe not checking the instanceId of a matomo anymore when checking if an archive is already running.

Basically, if the current instance defines an instanceId, then Matomo should only consider commands that include the instanceId.

We have at any time eg many “day” archives running but for different --matomo-domain . I wonder if it maybe thinks there’s an archive running but it’s for a different domain.
We used to check for this indirectly here (as the command includes the --matomo-domain) https://github.com/matomo-org/matomo/blob/3.14.1/core/CliMulti.php#L323-L331
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Dec 17, 2020
@tsteur tsteur added this to the 4.0.x milestone Dec 17, 2020
tsteur added a commit that referenced this issue Dec 17, 2020
@tsteur
Check for instanceIds when checking for currently running archive pro…
d1697ed 
…cesses

fix #16973
@tsteur tsteur mentioned this issue Dec 17, 2020
Merged
9 tasks
diosmosis pushed a commit that referenced this issue Dec 17, 2020
@tsteur
Check for instanceIds when checking for currently running archive pro…
00f0c9d 
…cesses (#16974)

fix #16973
@mattab mattab changed the title Detection of archive process already in progress does not check for instance ID core:archive Detection of archive process already in progress does not check for instance ID Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging a pull request may close this issue.

Check for instanceIds when checking for currently running archive processes matomo-org/matomo
1 participant
@tsteur