@sgiehl opened this Pull Request on December 17th 2020 Member

Description:

fixes #16953

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on December 17th 2020 Member

worked for me. A downside was that it said "matomo.js" is not writable when it should have maybe said eg misc/user/foo/matomo.js is not writable but then we might also not want to disclose this path + it's an edge case that someone overwrites the path like this (which is basically only us) so all good.

This Pull Request was closed on December 17th 2020
Powered by GitHub Issue Mirror