Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded code #16968

Merged
merged 2 commits into from Dec 17, 2020
Merged

Remove unneeded code #16968

merged 2 commits into from Dec 17, 2020

Conversation

diosmosis
Copy link
Member

Description:

An unneeded optimization.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 17, 2020
if ($value === false) {
$value = $this->rawLogDao->getMinimumVisitTimeForSite($idSite);
if (!empty($value)) {
$cache->save($cacheKey, $value, $ttl = self::MIN_VISIT_TIME_TTL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess that constant could be removed as well. Seems it was used nowhere else.

@tsteur tsteur added this to the 4.1.0 milestone Dec 17, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 17, 2020
@tsteur
Copy link
Member

tsteur commented Dec 17, 2020

Great that we can remove it 👍

@diosmosis diosmosis merged commit 42b398c into 4.x-dev Dec 17, 2020
@diosmosis diosmosis deleted the remove-unneeded branch December 17, 2020 23:43
@MichaIng
Copy link
Contributor

MichaIng commented Dec 18, 2020

Ah great, that seems to have fixed part of my issue here, where nothing was archived anymore, hence no reports created: #16978
The two conditional return false; seem to have broken archiving in my case. The syntax error when visiting privacy manager remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants