@diosmosis opened this Pull Request on December 17th 2020 Member

Description:

An unneeded optimization.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on December 17th 2020 Member

Great that we can remove it 👍

@MichaIng commented on December 18th 2020

Ah great, that seems to have fixed part of my issue here, where nothing was archived anymore, hence no reports created: #16978
The two conditional return false; seem to have broken archiving in my case. The syntax error when visiting privacy manager remains.

This Pull Request was closed on December 17th 2020
Powered by GitHub Issue Mirror