Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate archives after deleting a visit to prevent race conditions #16967

Merged
merged 2 commits into from Dec 18, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 16, 2020

Description:

The deletion of visits can take a while. To prevent any possible race condition we should invalidate archives only after the visits were deleted.

We recently deleted few visits and noticed the reports are still showing the wrong data. Not sure if this was the problem but be still good to change.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

The deletion of visits can take a while. To prevent any possible race condition we should invalidate archives only after the visits were deleted.

We recently deleted few visits and noticed the reports are still showing the wrong data. Not sure if this was the problem but be still good to change.
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 16, 2020
@tsteur tsteur added this to the 4.1.0 milestone Dec 16, 2020
@diosmosis diosmosis merged commit ecda65f into 4.x-dev Dec 18, 2020
@diosmosis diosmosis deleted the visitsarchivein branch December 18, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants