Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imprint URL to Template.pageFooter #16966

Merged
merged 3 commits into from Dec 31, 2020
Merged

Add imprint URL to Template.pageFooter #16966

merged 3 commits into from Dec 31, 2020

Conversation

wedi
Copy link
Contributor

@wedi wedi commented Dec 16, 2020

Description:

This pull request is a follow up on PR #13219 and adds an imprint URL to the page footer.

Fixes: #16965

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible - but not tested, see above
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@wedi wedi mentioned this pull request Dec 16, 2020
Closed
@wedi
Copy link
Contributor Author

wedi commented Dec 16, 2020

My first idea was to switch to a multituple (label and URL) to handle future requests for more URLs, too, but in the end I went with this simple solution as I couldn't deduct a way to handle label translations from the existing code I read.

@tsteur tsteur added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 16, 2020
@tsteur tsteur added this to the 4.1.0 milestone Dec 16, 2020
diosmosis
diosmosis requested changes Dec 18, 2020
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally, and the code looks good. I left one comment regarding translations, once it's fixed this can be merged. Thanks for the first contribution @wedi!

plugins/PrivacyManager/lang/de.json Outdated Show resolved Hide resolved
@mattab mattab modified the milestones: 4.1.0, 4.2.0 Dec 21, 2020
@diosmosis diosmosis merged commit 28085aa into matomo-org:4.x-dev Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Add imprint URL to Template.pageFooter
4 participants
@wedi @diosmosis @tsteur @mattab