Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArchiveInvalidatorTests for PHP 8 #16960

Merged
merged 1 commit into from Dec 15, 2020
Merged

Fix ArchiveInvalidatorTests for PHP 8 #16960

merged 1 commit into from Dec 15, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 15, 2020

Those tests are throwing an exception on PHP 8:
reset(): Argument #1 ($array) must be passed by reference, value given
Seems array_map('reset', $array); is not possible on PHP 8 anymore.

refs #16897

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 15, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Dec 15, 2020
@diosmosis diosmosis merged commit 2a7b481 into 4.x-dev Dec 15, 2020
@diosmosis diosmosis deleted the php8testfix branch December 15, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis