Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use Date class in Loader::getMinVisitTimesPerSite() to avoid using Dates w/ strange visit data. #16957

Merged
merged 1 commit into from Dec 15, 2020
Merged

Do not use Date class in Loader::getMinVisitTimesPerSite() to avoid using Dates w/ strange visit data. #16957

merged 1 commit into from Dec 15, 2020

Conversation

diosmosis
Copy link
Member

Description:

Fixes #16937

The user had a visit with a visit_last_action_time of 2. Opted to not use the Date class at all to keep the relevant query as simple as possible.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 15, 2020
@diosmosis diosmosis added this to the 4.1.0 milestone Dec 15, 2020
@diosmosis diosmosis mentioned this pull request Dec 15, 2020
Closed
@diosmosis diosmosis merged commit 023b5e2 into 4.x-dev Dec 15, 2020
@diosmosis diosmosis deleted the 16937-strange-date branch December 15, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Uncaught exception: Date.php: The date '1970-01-01' is a date before first website was online.
2 participants
@diosmosis @sgiehl