Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core:archive Only mark process as finished after fully sending the output #16952

Merged
merged 1 commit into from Dec 15, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 14, 2020

Description:

Otherwise there could be a race condition in cli multi where it thinks the process is finished, but the output hasn't been sent and written yet. Thus ending up with an "empty response" error under circumstances or only reading a partial output. This should only affect Matomo for WordPress though

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

Otherwise there could be a race condition in cli multi where it thinks the process is finished, but the output hasn't been sent and written yet. Thus ending up with an "empty response" error under circumstances or only reading a partial output. This should only affect Matomo for WordPress though
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 14, 2020
@tsteur tsteur added this to the 4.1.0 milestone Dec 14, 2020
@diosmosis diosmosis merged commit caec48a into 4.x-dev Dec 15, 2020
@diosmosis diosmosis deleted the climultirequestcommandoutput branch December 15, 2020 03:42
@mattab mattab changed the title Only mark process as finished after fully sending the output core:archive Only mark process as finished after fully sending the output Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants