Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core:archive Fix intersecting period logic so proper archives will archive in parallel. #16946

Merged
merged 1 commit into from Dec 17, 2020
Merged

core:archive Fix intersecting period logic so proper archives will archive in parallel. #16946

merged 1 commit into from Dec 17, 2020

Conversation

diosmosis
Copy link
Member

Description:

FYI @tsteur

Allows segment archives w/ same period to archive together.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Dec 14, 2020
@tsteur tsteur requested a review from sgiehl December 14, 2020 22:06
@tsteur tsteur added this to the 4.1.0 milestone Dec 14, 2020
@tsteur
Copy link
Member

tsteur commented Dec 14, 2020

I'll put it for now into 4.1 but we can always change it if/when needed

sgiehl
sgiehl reviewed Dec 15, 2020
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Tried to test that locally by starting multiple archivers but not sure if there is something special to look at. Seems all archivers were working smoothly concurrent, seems nothing was done twice or skipped...

@diosmosis
Copy link
Member Author

@tsteur fyi merging this

@diosmosis diosmosis merged commit 4a241a7 into 4.x-dev Dec 17, 2020
@diosmosis diosmosis deleted the archive-concurrency branch December 17, 2020 01:43
@mattab mattab changed the title Fix intersecting period logic so proper archives will archive in parallel. core:archive Fix intersecting period logic so proper archives will archive in parallel. Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @tsteur @sgiehl